From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: dw-hdmi-qp: fix multi-channel audio output
Date: Tue, 03 Mar 2026 14:21:01 +1000 [thread overview]
Message-ID: <review-overall-20260228112822.4056354-1-christianshewitt@gmail.com> (raw)
In-Reply-To: <20260228112822.4056354-1-christianshewitt@gmail.com>
Overall Series Review
Subject: drm/bridge: dw-hdmi-qp: fix multi-channel audio output
Author: Christian Hewitt <christianshewitt@gmail.com>
Patches: 1
Reviewed: 2026-03-03T14:21:01.926357
---
This is a single patch (v2) that fixes an off-by-3 buffer offset error when writing the HDMI Audio InfoFrame in the `dw-hdmi-qp` bridge driver. The fix is **correct and straightforward**. The commit message is clear, has proper tags (Fixes, Reported-by, Signed-off-by, Reviewed-by), and the change is minimal and targeted.
**Note on applicability to drm-next:** The patch targets the older version of `dw_hdmi_qp_config_audio_infoframe()` which used three individual `regmap_bulk_write()` calls. In the current drm-next tree, this function has been refactored to `dw_hdmi_qp_bridge_write_audio_infoframe()` and now uses the generic `dw_hdmi_qp_write_infoframe()` helper, which iterates over the entire buffer with correct offsets. This means **the bug has already been fixed in drm-next as a side effect of the refactoring**. However, the patch is still valuable for stable backports to kernels that have the original code (commit `fd0141d1a8a2`).
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 4:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 11:28 [PATCH v2] drm/bridge: dw-hdmi-qp: fix multi-channel audio output Christian Hewitt
2026-03-03 4:21 ` Claude Code Review Bot [this message]
2026-03-03 4:21 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260228112822.4056354-1-christianshewitt@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox