From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: dw-hdmi-qp: fix multi-channel audio output Date: Tue, 03 Mar 2026 14:21:01 +1000 Message-ID: In-Reply-To: <20260228112822.4056354-1-christianshewitt@gmail.com> References: <20260228112822.4056354-1-christianshewitt@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: dw-hdmi-qp: fix multi-channel audio output Author: Christian Hewitt Patches: 1 Reviewed: 2026-03-03T14:21:01.926357 --- This is a single patch (v2) that fixes an off-by-3 buffer offset error when writing the HDMI Audio InfoFrame in the `dw-hdmi-qp` bridge driver. The fix is **correct and straightforward**. The commit message is clear, has proper tags (Fixes, Reported-by, Signed-off-by, Reviewed-by), and the change is minimal and targeted. **Note on applicability to drm-next:** The patch targets the older version of `dw_hdmi_qp_config_audio_infoframe()` which used three individual `regmap_bulk_write()` calls. In the current drm-next tree, this function has been refactored to `dw_hdmi_qp_bridge_write_audio_infoframe()` and now uses the generic `dw_hdmi_qp_write_infoframe()` helper, which iterates over the entire buffer with correct offsets. This means **the bug has already been fixed in drm-next as a side effect of the refactoring**. However, the patch is still valuable for stable backports to kernels that have the original code (commit `fd0141d1a8a2`). --- Generated by Claude Code Patch Reviewer