From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: i915: Fix NULL pointer dereference in intel_dmc_update_dc6_allowed_count()
Date: Tue, 03 Mar 2026 14:19:14 +1000 [thread overview]
Message-ID: <review-overall-20260228130946.50919-2-ltao@redhat.com> (raw)
In-Reply-To: <20260228130946.50919-2-ltao@redhat.com>
Overall Series Review
Subject: i915: Fix NULL pointer dereference in intel_dmc_update_dc6_allowed_count()
Author: Tao Liu <ltao@redhat.com>
Patches: 3
Reviewed: 2026-03-03T14:19:14.663558
---
This is a single-patch fix for a real NULL pointer dereference crash in `intel_dmc_update_dc6_allowed_count()` during kdump's second kernel boot. The bug is legitimate: `display_to_dmc()` is explicitly documented as potentially returning NULL (`/* Note: This may be NULL. */`), and the caller `gen9_set_dc_state()` invokes this function without any DMC existence check. Many other callers of `display_to_dmc()` in the same file already guard against NULL (e.g., `has_dmc_id_fw()`, `intel_pipedmc_start_mmioaddr()`, `intel_dmc_suspend()`, `intel_dmc_wait_fw_load()`).
The fix is correct and follows the established codebase pattern. A few minor improvements could be suggested.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 4:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 13:09 [PATCH] i915: Fix NULL pointer dereference in intel_dmc_update_dc6_allowed_count() Tao Liu
2026-03-02 9:14 ` Jani Nikula
2026-03-02 12:33 ` Tao Liu
2026-03-03 4:19 ` Claude Code Review Bot [this message]
2026-03-03 4:19 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260228130946.50919-2-ltao@redhat.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox