From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: i915: Fix NULL pointer dereference in intel_dmc_update_dc6_allowed_count() Date: Tue, 03 Mar 2026 14:19:14 +1000 Message-ID: In-Reply-To: <20260228130946.50919-2-ltao@redhat.com> References: <20260228130946.50919-2-ltao@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: i915: Fix NULL pointer dereference in intel_dmc_update_dc6_allowed_count() Author: Tao Liu Patches: 3 Reviewed: 2026-03-03T14:19:14.663558 --- This is a single-patch fix for a real NULL pointer dereference crash in `intel_dmc_update_dc6_allowed_count()` during kdump's second kernel boot. The bug is legitimate: `display_to_dmc()` is explicitly documented as potentially returning NULL (`/* Note: This may be NULL. */`), and the caller `gen9_set_dc_state()` invokes this function without any DMC existence check. Many other callers of `display_to_dmc()` in the same file already guard against NULL (e.g., `has_dmc_id_fw()`, `intel_pipedmc_start_mmioaddr()`, `intel_dmc_suspend()`, `intel_dmc_wait_fw_load()`). The fix is correct and follows the established codebase pattern. A few minor improvements could be suggested. --- Generated by Claude Code Patch Reviewer