From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: staging: fbtft: replace -1 with proper error codes
Date: Tue, 03 Mar 2026 14:07:12 +1000 [thread overview]
Message-ID: <review-overall-20260228202701.43337-1-officialsohamkute@gmail.com> (raw)
In-Reply-To: <20260228202701.43337-1-officialsohamkute@gmail.com>
Overall Series Review
Subject: staging: fbtft: replace -1 with proper error codes
Author: Soham Kute <officialsohamkute@gmail.com>
Patches: 1
Reviewed: 2026-03-03T14:07:12.200424
---
This is a straightforward single-patch cleanup that replaces bare `return -1` with proper kernel error codes across three files in `drivers/staging/fbtft/`. The change is correct in principle — returning `-1` (which maps to `-EPERM`) from these functions is incorrect and misleading. The chosen error codes are mostly reasonable and well-matched to the failure conditions. This is typical staging cleanup work.
One minor quibble with error code selection (see below), but overall this is a clean, correct patch.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 4:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 20:27 [PATCH] staging: fbtft: replace -1 with proper error codes Soham Kute
2026-03-03 4:07 ` Claude Code Review Bot [this message]
2026-03-03 4:07 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260228202701.43337-1-officialsohamkute@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox