From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: staging: fbtft: replace -1 with proper error codes Date: Tue, 03 Mar 2026 14:07:12 +1000 Message-ID: In-Reply-To: <20260228202701.43337-1-officialsohamkute@gmail.com> References: <20260228202701.43337-1-officialsohamkute@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: staging: fbtft: replace -1 with proper error codes Author: Soham Kute Patches: 1 Reviewed: 2026-03-03T14:07:12.200424 --- This is a straightforward single-patch cleanup that replaces bare `return -= 1` with proper kernel error codes across three files in `drivers/staging/fb= tft/`. The change is correct in principle =E2=80=94 returning `-1` (which m= aps to `-EPERM`) from these functions is incorrect and misleading. The chos= en error codes are mostly reasonable and well-matched to the failure condit= ions. This is typical staging cleanup work. One minor quibble with error code selection (see below), but overall this i= s a clean, correct patch. --- Generated by Claude Code Patch Reviewer