Claude review: accel/amdxdna: Import AMD_PMF namespace

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: accel/amdxdna: Import AMD_PMF namespace
Author: "Mario Limonciello (AMD)" <superm1@kernel.org>
Patches: 2
Reviewed: 2026-03-03T14:05:57.418611

---

This is a single, trivially small patch that adds `MODULE_IMPORT_NS("AMD_PMF")` to the amdxdna accelerator driver. The stated purpose is to allow the driver to call `amd_pmf_get_npu_data()`, which is exported in the `AMD_PMF` namespace from `drivers/platform/x86/amd/pmf/core.c`.

The patch is **correct in form** — adding a `MODULE_IMPORT_NS()` is the right way to consume a symbol exported with `EXPORT_SYMBOL_NS_GPL()`. However, there is a significant concern: **the current amdxdna driver on drm-next has no reference to `amd_pmf_get_npu_data()` or any `amd_pmf` API at all**. This means the namespace import is being added ahead of the code that actually uses it, or depends on another patch (or series) that hasn't landed yet.

This is fine if this patch is intended to be applied on top of another series that adds the actual `amd_pmf_get_npu_data()` call, but the commit message should state this dependency explicitly (e.g., referencing the other series or commit). Without that context, the patch appears to add a namespace import for a symbol that is never used, which would be dead code.

---
Generated by Claude Code Patch Reviewer