From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/ethosu propagate devm_drm_dev_alloc() error code
Date: Tue, 03 Mar 2026 14:00:36 +1000 [thread overview]
Message-ID: <review-overall-20260301090411.171060-1-alok.a.tiwari@oracle.com> (raw)
In-Reply-To: <20260301090411.171060-1-alok.a.tiwari@oracle.com>
Overall Series Review
Subject: accel/ethosu propagate devm_drm_dev_alloc() error code
Author: Alok Tiwari <alok.a.tiwari@oracle.com>
Patches: 1
Reviewed: 2026-03-03T14:00:36.219557
---
This is a single, trivial, and correct bugfix patch. It changes a hardcoded `-ENOMEM` error return to properly propagate the actual error code from `devm_drm_dev_alloc()` using `PTR_ERR()`. The fix is appropriate since `devm_drm_dev_alloc()` can return various error codes (e.g., `-ENOMEM`, `-EINVAL`, `-ENODEV`), and callers should propagate whatever error it actually returned rather than assuming `-ENOMEM`.
The patch is clean, minimal, and well-described. No concerns.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 4:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 9:03 [PATCH] accel/ethosu propagate devm_drm_dev_alloc() error code Alok Tiwari
2026-03-03 4:00 ` Claude Code Review Bot [this message]
2026-03-03 4:00 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260301090411.171060-1-alok.a.tiwari@oracle.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox