[PATCH v2] dt-bindings: display/msm/gpu: Drop redundant reg-names in one if:then:

[PATCH v2] dt-bindings: display/msm/gpu: Drop redundant reg-names in one if:then:

[Krzysztof Kozlowski]

Top-level reg-names defines already proper order for "reg-names" with
minItems: 1, so no need to repeat it again in one of "if:then:" cases.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Changes in v2:
1. Rebase
---
 Documentation/devicetree/bindings/display/msm/gpu.yaml | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml
index ec84b64d4c00..04b2328903ca 100644
--- a/Documentation/devicetree/bindings/display/msm/gpu.yaml
+++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
@@ -440,13 +440,6 @@ allOf:
         clocks: false
         clock-names: false
 
-        reg-names:
-          minItems: 1
-          items:
-            - const: kgsl_3d0_reg_memory
-            - const: cx_mem
-            - const: cx_dbgc
-
 examples:
   - |
 
-- 
2.51.0

Re: [PATCH v2] dt-bindings: display/msm/gpu: Drop redundant reg-names in one if:then:

[David Heidelberg]

On 01/03/2026 15:20, Krzysztof Kozlowski wrote:
> Top-level reg-names defines already proper order for "reg-names" with
> minItems: 1, so no need to repeat it again in one of "if:then:" cases.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---
> 
> Changes in v2:
> 1. Rebase
> ---

Reviewed-by: David Heidelberg <david@ixit.cz>

[...]
-- 
David Heidelberg

Re: [PATCH v2] dt-bindings: display/msm/gpu: Drop redundant reg-names in one if:then:

[Dmitry Baryshkov]

On Sun, Mar 01, 2026 at 03:20:34PM +0100, Krzysztof Kozlowski wrote:
> Top-level reg-names defines already proper order for "reg-names" with
> minItems: 1, so no need to repeat it again in one of "if:then:" cases.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Claude review: dt-bindings: display/msm/gpu: Drop redundant reg-names in one if:then:

[Claude Code Review Bot]

Overall Series Review

Subject: dt-bindings: display/msm/gpu: Drop redundant reg-names in one if:then:
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Patches: 3
Reviewed: 2026-03-03T13:51:52.484564

---

This is a single-patch cleanup that removes a redundant `reg-names` constraint from one `if:then:` block in the MSM GPU device-tree binding schema. The change is correct and straightforward — the removed block is an exact duplicate of the top-level `reg-names` definition and adds no additional constraint.

**Verdict: Patch looks good.**

---
Generated by Claude Code Patch Reviewer

Claude review: dt-bindings: display/msm/gpu: Drop redundant reg-names in one if:then:

[Claude Code Review Bot]

Patch Review

**Correctness: OK**

The top-level schema already defines `reg-names` at lines 59–64 of `gpu.yaml`:

```yaml
  reg-names:
    minItems: 1
    items:
      - const: kgsl_3d0_reg_memory
      - const: cx_mem
      - const: cx_dbgc
```

The removed block (inside the A6xx GMU `then:` clause, lines 443–448) is character-for-character identical:

```yaml
        reg-names:
          minItems: 1
          items:
            - const: kgsl_3d0_reg_memory
            - const: cx_mem
            - const: cx_dbgc
```

Since JSON Schema `allOf` creates an intersection of constraints, restating the same constraint in a `then:` block is a no-op. Removing it is the right thing to do.

**Contrast with the adreno-612.0 block (lines 400–408):** That `if:then:` also has a `reg-names` block, but it is *not* redundant — it works together with its sibling `reg: minItems: 3, maxItems: 3` to enforce that all three register regions must be present for that specific SoC. The top-level only requires `minItems: 1`, so the 612.0 override is meaningful and correctly left in place.

**Minor note:** The commit message says "Top-level reg-names defines already proper order for 'reg-names' with minItems: 1" — this is accurate, since the top-level `items` array already constrains the names and their ordering.

**No issues found.** 

Reviewed-by is warranted.

---
Generated by Claude Code Patch Reviewer