From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: rename `kernel::c_str!` to `str_to_cstr!` Date: Tue, 03 Mar 2026 13:00:33 +1000 Message-ID: In-Reply-To: <20260302-cstr-rename-macro-v1-1-a269fe4dc3f0@kernel.org> References: <20260302-cstr-rename-macro-v1-1-a269fe4dc3f0@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: rust: rename `kernel::c_str!` to `str_to_cstr!` Author: Tamir Duberstein Patches: 3 Reviewed: 2026-03-03T13:00:33.239684 --- This is a single-patch rename of the `kernel::c_str!` macro to `kernel::str_to_cstr!`. The motivation is that since Rust 1.77, C string literals (`c"..."`) are the preferred way to create `&CStr` values from string literals, and this macro now only exists for non-literal cases (e.g., wrapping `stringify!()`, `concat!()`, `file!()` in macro contexts). The rename makes its narrower intended purpose explicit. The patch is clean, mechanical, and complete. All 8 call sites within `rust/kernel/` are updated, which matches the full set of files found via grep. The macro is not in the prelude and has no external consumers in-tree (drivers, samples, etc.), so nothing is missed. The updated documentation clearly describes why the macro still exists and when to use it versus C string literals. Already has Acked-by from Greg Kroah-Hartman and Reviewed-by from Alice Ryhl. **Verdict:** This looks correct and ready to merge with one very minor nit. --- Generated by Claude Code Patch Reviewer