From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/mdp5: Remove MSM8974v1
Date: Tue, 03 Mar 2026 13:20:38 +1000 [thread overview]
Message-ID: <review-overall-20260302-topic-goodnight_8974v1-v1-1-e0006f7a0526@oss.qualcomm.com> (raw)
In-Reply-To: <20260302-topic-goodnight_8974v1-v1-1-e0006f7a0526@oss.qualcomm.com>
Overall Series Review
Subject: drm/msm/mdp5: Remove MSM8974v1
Author: Konrad Dybcio <konradybcio@kernel.org>
Patches: 2
Reviewed: 2026-03-03T13:20:38.128002
---
This is a single cleanup patch that removes the MSM8974v1 MDP5 configuration from the driver, with the rationale that the v1 silicon was never shipped in any consumer device. The patch is straightforward: it deletes the `msm8x74v1_config` struct, removes the corresponding `cfg_handlers_v1` entry for revision 0, and renames `msm8x74v2_config` to `msm8x74_config` to align with naming elsewhere in the kernel.
The change is clean and well-motivated. There is one minor cosmetic issue and one point worth confirming, but neither is blocking.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-03 3:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 13:41 [PATCH] drm/msm/mdp5: Remove MSM8974v1 Konrad Dybcio
2026-03-02 13:57 ` Dmitry Baryshkov
2026-03-03 3:20 ` Claude review: " Claude Code Review Bot
2026-03-03 3:20 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260302-topic-goodnight_8974v1-v1-1-e0006f7a0526@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox