From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: vc,fbcon,fonts: Proper handling of font data Date: Tue, 03 Mar 2026 13:19:13 +1000 Message-ID: In-Reply-To: <20260302141255.518657-1-tzimmermann@suse.de> References: <20260302141255.518657-1-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: vc,fbcon,fonts: Proper handling of font data Author: Thomas Zimmermann Patches: 14 Reviewed: 2026-03-03T13:19:13.472651 --- This is a well-structured 13-patch series by Thomas Zimmermann that introduces proper abstractions for console font data handling across VT, fbcon, newport_con, and the lib/fonts infrastructure. The series replaces open-coded font data manipulation (raw pointer arithmetic with hidden headers) with typed helpers (`font_data_t`, `font_data_get/put`, `font_data_import/export`, etc.), introduces `struct vc_font` to replace the UAPI `struct console_font` in kernel internals, and cleans up reference counting by removing the `userfont` flag from fbcon. The overall direction is sound and the incremental patch ordering makes the series reviewable. However, there are several issues ranging from minor typos to a potentially problematic functional change in font export and some missing overflow/underflow protections in the new centralized helpers. **Key concerns:** - `font_data_export()` has a potential underflow if `vpitch < font->height` (caller-validated but not self-protecting) - The removal of the width 17-24 special-case export path is a behavioral change that needs careful validation - `font_data_import()` doesn't overflow-check the source-side index `i * vpitch * pitch` - Several typos in documentation comments across multiple patches --- --- Generated by Claude Code Patch Reviewer