From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Two-pass MMU interval notifiers Date: Tue, 03 Mar 2026 13:05:43 +1000 Message-ID: In-Reply-To: <20260302163248.105454-1-thomas.hellstrom@linux.intel.com> References: <20260302163248.105454-1-thomas.hellstrom@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Two-pass MMU interval notifiers Author: =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= Patches: 15 Reviewed: 2026-03-03T13:05:43.927349 --- This series adds two-pass MMU interval notifier support to enable overlapping GPU operations (TLB flushes, context preemption) across multiple GPUs in multi-GPU scenarios. The motivation is sound: instead of serializing notify-then-wait per-GPU, the first pass kicks off operations on all GPUs, and the second pass waits for them all. The series is well-structured, with patch 1 providing the core mm infrastructure, patch 2 converting xe userptr to the two-pass model, patch 3 refactoring TLB invalidation into submit/wait halves, and patch 4 wiring up deferred TLB waits through the two-pass mechanism. Overall the design is reasonable and the code is generally clean. There are a few issues to address, ranging from a real bug (static local variable in patch 2) to design concerns about the three-pass usage in patch 4 abusing the two-pass infrastructure. --- --- Generated by Claude Code Patch Reviewer