From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vmwgfx: Don't overwrite KMS surface dirty tracker
Date: Tue, 03 Mar 2026 12:53:48 +1000 [thread overview]
Message-ID: <review-overall-20260302200330.66763-1-ian.forbes@broadcom.com> (raw)
In-Reply-To: <20260302200330.66763-1-ian.forbes@broadcom.com>
Overall Series Review
Subject: drm/vmwgfx: Don't overwrite KMS surface dirty tracker
Author: Ian Forbes <ian.forbes@broadcom.com>
Patches: 1
Reviewed: 2026-03-03T12:53:48.222615
---
This is a single-patch fix for a memory leak in the vmwgfx KMS framebuffer creation path. The fix is correct and well-targeted. When `vmw_kms_fb_create` is called for a surface that already has a dirty tracker allocated (i.e., `surface->res.dirty != NULL`), the code was unconditionally calling `dirty_alloc()`, which allocates a new dirty tracker and assigns it to `res->dirty` (see `vmwgfx_surface.c:2040`), overwriting the old pointer and leaking that memory. The fix simply guards the allocation with a NULL check, which is the right approach.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-03 2:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 20:03 [PATCH] drm/vmwgfx: Don't overwrite KMS surface dirty tracker Ian Forbes
2026-03-03 2:53 ` Claude review: " Claude Code Review Bot
2026-03-03 2:53 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260302200330.66763-1-ian.forbes@broadcom.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox