From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vmwgfx: Don't overwrite KMS surface dirty tracker Date: Tue, 03 Mar 2026 12:53:48 +1000 Message-ID: In-Reply-To: <20260302200330.66763-1-ian.forbes@broadcom.com> References: <20260302200330.66763-1-ian.forbes@broadcom.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/vmwgfx: Don't overwrite KMS surface dirty tracker Author: Ian Forbes Patches: 1 Reviewed: 2026-03-03T12:53:48.222615 --- This is a single-patch fix for a memory leak in the vmwgfx KMS framebuffer creation path. The fix is correct and well-targeted. When `vmw_kms_fb_create` is called for a surface that already has a dirty tracker allocated (i.e., `surface->res.dirty != NULL`), the code was unconditionally calling `dirty_alloc()`, which allocates a new dirty tracker and assigns it to `res->dirty` (see `vmwgfx_surface.c:2040`), overwriting the old pointer and leaking that memory. The fix simply guards the allocation with a NULL check, which is the right approach. --- Generated by Claude Code Patch Reviewer