From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/ivpu: Limit number of maximum contexts and doorbells per user
Date: Tue, 03 Mar 2026 12:50:56 +1000 [thread overview]
Message-ID: <review-overall-20260302202207.469442-1-maciej.falkowski@linux.intel.com> (raw)
In-Reply-To: <20260302202207.469442-1-maciej.falkowski@linux.intel.com>
Overall Series Review
Subject: accel/ivpu: Limit number of maximum contexts and doorbells per user
Author: Maciej Falkowski <maciej.falkowski@linux.intel.com>
Patches: 2
Reviewed: 2026-03-03T12:50:56.418884
---
This is a single patch (v3) that adds per-user resource limits for contexts and doorbells in the Intel IVPU (NPU) accelerator driver. The goal is to prevent a single user from monopolizing hardware resources on multi-user systems, with root getting full access and non-root users limited to half.
The overall design is reasonable: a hash table keyed by UID tracks per-user limits, kref-counted to the number of open file descriptors. The doorbell limit uses an atomic increment-then-check pattern that is correct. However, there are several issues ranging from a likely off-by-one to a security anti-pattern and mixed-in unrelated formatting changes.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 2:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 20:22 [PATCH v3] accel/ivpu: Limit number of maximum contexts and doorbells per user Maciej Falkowski
2026-03-02 20:45 ` Lizhi Hou
2026-03-03 2:50 ` Claude review: " Claude Code Review Bot
2026-03-03 2:50 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-02-25 18:06 [PATCH v2] " Maciej Falkowski
2026-02-27 3:00 ` Claude review: " Claude Code Review Bot
2026-02-27 3:00 ` Claude Code Review Bot
2026-02-20 16:00 [PATCH] " Maciej Falkowski
2026-02-20 19:58 ` Claude review: " Claude Code Review Bot
2026-02-20 19:58 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260302202207.469442-1-maciej.falkowski@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox