From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/ivpu: Limit number of maximum contexts and doorbells per user Date: Tue, 03 Mar 2026 12:50:56 +1000 Message-ID: In-Reply-To: <20260302202207.469442-1-maciej.falkowski@linux.intel.com> References: <20260302202207.469442-1-maciej.falkowski@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: accel/ivpu: Limit number of maximum contexts and doorbells per user Author: Maciej Falkowski Patches: 2 Reviewed: 2026-03-03T12:50:56.418884 --- This is a single patch (v3) that adds per-user resource limits for contexts and doorbells in the Intel IVPU (NPU) accelerator driver. The goal is to prevent a single user from monopolizing hardware resources on multi-user systems, with root getting full access and non-root users limited to half. The overall design is reasonable: a hash table keyed by UID tracks per-user limits, kref-counted to the number of open file descriptors. The doorbell limit uses an atomic increment-then-check pattern that is correct. However, there are several issues ranging from a likely off-by-one to a security anti-pattern and mixed-in unrelated formatting changes. --- Generated by Claude Code Patch Reviewer