From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: heaps: Turn heaps into modules Date: Wed, 04 Mar 2026 07:41:35 +1000 Message-ID: In-Reply-To: <20260303-dma-buf-heaps-as-modules-v3-0-24344812c707@kernel.org> References: <20260303-dma-buf-heaps-as-modules-v3-0-24344812c707@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: dma-buf: heaps: Turn heaps into modules Author: Maxime Ripard Patches: 9 Reviewed: 2026-03-04T07:41:35.266050 --- **Author**: Maxime Ripard **Series**: dma-buf: heaps: Turn heaps into modules (v3, 8 patches) This series enables the CMA and system dma-buf heaps to be compiled as load= able modules (tristate). The approach is well-structured: patches 1-6 prepa= re the prerequisites (inverting the CMA registration logic, exporting neces= sary symbols), and patches 7-8 make the actual `bool` =E2=86=92 `tristate` = Kconfig changes. The overall design is sound. Inverting the registration so the heap queries= the contiguous DMA code (rather than the contiguous code calling into the = heap) is the right way to break the built-in =E2=86=92 module dependency. T= he patches are generally well-separated with clear commit messages. **However, there is a build-breaking bug:** patch 1 removes the `dma_heap_c= ma_register_heap()` function definition from `cma_heap.c`, but the call sit= e at `kernel/dma/contiguous.c:276` and the header declaration in `include/l= inux/dma-buf/heaps/cma.h` are left behind. This causes a **link error** whe= n `CONFIG_DMABUF_HEAPS_CMA=3Dy`. Details below. --- --- Generated by Claude Code Patch Reviewer