From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdkfd: remove duplicate ttmp11 scheduling mode definitions
Date: Wed, 04 Mar 2026 08:32:56 +1000 [thread overview]
Message-ID: <review-overall-20260303-drm-amdkfd-ttmp11-sched-mode-v1-1-8130e3e6fcae@redhat.com> (raw)
In-Reply-To: <20260303-drm-amdkfd-ttmp11-sched-mode-v1-1-8130e3e6fcae@redhat.com>
Overall Series Review
Subject: drm/amdkfd: remove duplicate ttmp11 scheduling mode definitions
Author: Peter Colberg <pcolberg@redhat.com>
Patches: 1
Reviewed: 2026-03-04T08:32:56.895305
---
This is a single-patch cleanup that removes duplicate variable definitions (`TTMP11_SCHED_MODE_SHIFT`, `TTMP11_SCHED_MODE_SIZE`, `TTMP11_SCHED_MODE_MASK`) in the GFX12 CWSR trap handler assembly file. The variables were defined twice: once inside a `#if RELAXED_SCHEDULING_IN_TRAP` guard (lines 112-117 pre-patch) and once unconditionally (lines 134-136 pre-patch). The patch removes the first (guarded) copy and wraps the second (previously unconditional) copy with the `#if RELAXED_SCHEDULING_IN_TRAP` guard.
The fix is correct, low-risk, and improves code quality. All usages of the `TTMP11_SCHED_MODE_*` variables are within `#if RELAXED_SCHEDULING_IN_TRAP` blocks, so conditionalizing the definitions is the right thing to do. The Fixes tag is appropriate since commit `bbcad5a8896b` introduced the duplication.
**Verdict: Looks good.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 22:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 21:29 [PATCH RESEND] drm/amdkfd: remove duplicate ttmp11 scheduling mode definitions Peter Colberg
2026-03-03 22:32 ` Claude Code Review Bot [this message]
2026-03-03 22:32 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-02-24 17:21 [PATCH] " Peter Colberg
2026-02-27 4:54 ` Claude review: " Claude Code Review Bot
2026-02-27 4:54 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260303-drm-amdkfd-ttmp11-sched-mode-v1-1-8130e3e6fcae@redhat.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox