From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdkfd: remove duplicate ttmp11 scheduling mode definitions Date: Wed, 04 Mar 2026 08:32:56 +1000 Message-ID: In-Reply-To: <20260303-drm-amdkfd-ttmp11-sched-mode-v1-1-8130e3e6fcae@redhat.com> References: <20260303-drm-amdkfd-ttmp11-sched-mode-v1-1-8130e3e6fcae@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/amdkfd: remove duplicate ttmp11 scheduling mode definitions Author: Peter Colberg Patches: 1 Reviewed: 2026-03-04T08:32:56.895305 --- This is a single-patch cleanup that removes duplicate variable definitions (`TTMP11_SCHED_MODE_SHIFT`, `TTMP11_SCHED_MODE_SIZE`, `TTMP11_SCHED_MODE_MASK`) in the GFX12 CWSR trap handler assembly file. The variables were defined twice: once inside a `#if RELAXED_SCHEDULING_IN_TRAP` guard (lines 112-117 pre-patch) and once unconditionally (lines 134-136 pre-patch). The patch removes the first (guarded) copy and wraps the second (previously unconditional) copy with the `#if RELAXED_SCHEDULING_IN_TRAP` guard. The fix is correct, low-risk, and improves code quality. All usages of the `TTMP11_SCHED_MODE_*` variables are within `#if RELAXED_SCHEDULING_IN_TRAP` blocks, so conditionalizing the definitions is the right thing to do. The Fixes tag is appropriate since commit `bbcad5a8896b` introduced the duplication. **Verdict: Looks good.** --- Generated by Claude Code Patch Reviewer