public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm: Add Qualcomm Eliza SoC support
Date: Wed, 04 Mar 2026 07:15:18 +1000	[thread overview]
Message-ID: <review-overall-20260303-drm-display-eliza-v1-0-814121dbb2bf@oss.qualcomm.com> (raw)
In-Reply-To: <20260303-drm-display-eliza-v1-0-814121dbb2bf@oss.qualcomm.com>

Overall Series Review

Subject: drm/msm: Add Qualcomm Eliza SoC support
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Patches: 24
Reviewed: 2026-03-04T07:15:18.579795

---

This is a well-structured 8-patch series from Krzysztof Kozlowski adding Qualcomm Eliza SoC display support, covering dt-bindings, UBWC configuration, DPU catalog, and MDSS registration. The Eliza SoC is described as an evolution of SM8750 with some blocks removed and HDMI added. The series follows established patterns and is cleanly organized. There are a few issues worth noting, one being a real bug and others being minor nits.

The most significant issue is in **patch 7** where `.cwb = sm8650_cwb` is used instead of the locally-defined `eliza_cwb`. While this mirrors a pre-existing pattern in SM8750/Glymur/Kaanapali catalogs, the local `eliza_cwb[]` array (with `.len = 0x20`) differs from `sm8650_cwb` (with `.len = 0x8`), meaning the locally-defined data is never actually used. Additionally, the DSC block `dce_1` only has one hard slice (DSC_2) without its pair (DSC_3), which looks unusual but may reflect actual hardware.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-03 21:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 13:07 [PATCH 0/8] drm/msm: Add Qualcomm Eliza SoC support Krzysztof Kozlowski
2026-03-03 13:07 ` [PATCH 1/8] dt-bindings: display/msm: dp-controller: Add Eliza SoC Krzysztof Kozlowski
2026-03-03 13:47   ` Dmitry Baryshkov
2026-03-03 14:02     ` Krzysztof Kozlowski
2026-03-03 21:15   ` Claude review: " Claude Code Review Bot
2026-03-03 13:07 ` [PATCH 2/8] dt-bindings: display/msm: dsi-phy-7nm: " Krzysztof Kozlowski
2026-03-03 13:47   ` Dmitry Baryshkov
2026-03-03 21:15   ` Claude review: " Claude Code Review Bot
2026-03-03 13:07 ` [PATCH 3/8] dt-bindings: display/msm: dsi-controller-main: " Krzysztof Kozlowski
2026-03-03 13:48   ` Dmitry Baryshkov
2026-03-03 21:15   ` Claude review: " Claude Code Review Bot
2026-03-03 13:07 ` [PATCH 4/8] dt-bindings: display/msm: qcom,sm8650-dpu: " Krzysztof Kozlowski
2026-03-03 13:49   ` [PATCH 4/8] dt-bindings: display/msm: qcom, sm8650-dpu: " Dmitry Baryshkov
2026-03-03 21:15   ` Claude review: dt-bindings: display/msm: qcom,sm8650-dpu: " Claude Code Review Bot
2026-03-03 13:07 ` [PATCH 5/8] dt-bindings: display/msm: qcom,eliza-mdss: " Krzysztof Kozlowski
2026-03-03 13:49   ` [PATCH 5/8] dt-bindings: display/msm: qcom, eliza-mdss: " Dmitry Baryshkov
2026-03-03 15:56   ` [PATCH 5/8] dt-bindings: display/msm: qcom,eliza-mdss: " Rob Herring (Arm)
2026-03-03 16:09     ` [PATCH 5/8] dt-bindings: display/msm: qcom, eliza-mdss: " Krzysztof Kozlowski
2026-03-03 21:15   ` Claude review: dt-bindings: display/msm: qcom,eliza-mdss: " Claude Code Review Bot
2026-03-03 13:07 ` [PATCH 6/8] soc: qcom: ubwc: Add configuration " Krzysztof Kozlowski
2026-03-03 13:12   ` Konrad Dybcio
2026-03-03 14:03     ` Krzysztof Kozlowski
2026-03-03 21:15   ` Claude review: " Claude Code Review Bot
2026-03-03 13:07 ` [PATCH 7/8] drm/msm/dpu: Add support for " Krzysztof Kozlowski
2026-03-03 14:08   ` Dmitry Baryshkov
2026-03-03 14:09     ` Krzysztof Kozlowski
2026-03-03 14:10   ` Dmitry Baryshkov
2026-03-03 16:22     ` Krzysztof Kozlowski
2026-03-03 21:15   ` Claude review: " Claude Code Review Bot
2026-03-03 13:07 ` [PATCH 8/8] drm/msm/mdss: " Krzysztof Kozlowski
2026-03-03 14:11   ` Dmitry Baryshkov
2026-03-03 21:15   ` Claude review: " Claude Code Review Bot
2026-03-03 21:15 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-03-04 12:58 [PATCH v2 0/8] drm/msm: Add Qualcomm Eliza SoC support Krzysztof Kozlowski
2026-03-05  3:31 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260303-drm-display-eliza-v1-0-814121dbb2bf@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox