From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: Add Qualcomm Eliza SoC support Date: Wed, 04 Mar 2026 07:15:18 +1000 Message-ID: In-Reply-To: <20260303-drm-display-eliza-v1-0-814121dbb2bf@oss.qualcomm.com> References: <20260303-drm-display-eliza-v1-0-814121dbb2bf@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm: Add Qualcomm Eliza SoC support Author: Krzysztof Kozlowski Patches: 24 Reviewed: 2026-03-04T07:15:18.579795 --- This is a well-structured 8-patch series from Krzysztof Kozlowski adding Qualcomm Eliza SoC display support, covering dt-bindings, UBWC configuration, DPU catalog, and MDSS registration. The Eliza SoC is described as an evolution of SM8750 with some blocks removed and HDMI added. The series follows established patterns and is cleanly organized. There are a few issues worth noting, one being a real bug and others being minor nits. The most significant issue is in **patch 7** where `.cwb = sm8650_cwb` is used instead of the locally-defined `eliza_cwb`. While this mirrors a pre-existing pattern in SM8750/Glymur/Kaanapali catalogs, the local `eliza_cwb[]` array (with `.len = 0x20`) differs from `sm8650_cwb` (with `.len = 0x8`), meaning the locally-defined data is never actually used. Additionally, the DSC block `dce_1` only has one hard slice (DSC_2) without its pair (DSC_3), which looks unusual but may reflect actual hardware. --- --- Generated by Claude Code Patch Reviewer