From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add HDMI 2.0 support to DW HDMI QP TX Date: Tue, 03 Mar 2026 12:42:54 +1000 Message-ID: In-Reply-To: <20260303-dw-hdmi-qp-scramb-v4-0-317d3b8bd219@collabora.com> References: <20260303-dw-hdmi-qp-scramb-v4-0-317d3b8bd219@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Add HDMI 2.0 support to DW HDMI QP TX Author: Cristian Ciocaltea Patches: 5 Reviewed: 2026-03-03T12:42:54.286151 --- This 4-patch series adds HDMI 2.0 support (modes above 340 MHz TMDS, like 4K@60Hz) to the Synopsys DesignWare HDMI QP TX bridge driver used on Rockchip RK3576/RK3588. The approach is sound: introduce an atomic `detect_ctx` bridge hook so the detect path can hold modeset locks and trigger a CRTC reset when SCDC scrambling state is lost on sink disconnect/reconnect. The series is well-structured with clean separation between the framework plumbing (patches 1-2) and the driver-specific changes (patches 3-4). There is one significant locking concern in patch 3 regarding `drm_bridge_helper_reset_crtc` being called while `connection_mutex` is already held by the same acquire context, and the EDEADLK handling calling `drm_modeset_backoff` on a context the function doesn't own. --- Generated by Claude Code Patch Reviewer