From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: msm: Fix reg ranges and clocks on Glymur
Date: Wed, 04 Mar 2026 07:43:55 +1000 [thread overview]
Message-ID: <review-overall-20260303-glymur-fix-dp-bindings-reg-clocks-v4-1-1ebd9c7c2cee@oss.qualcomm.com> (raw)
In-Reply-To: <20260303-glymur-fix-dp-bindings-reg-clocks-v4-1-1ebd9c7c2cee@oss.qualcomm.com>
Overall Series Review
Subject: dt-bindings: display: msm: Fix reg ranges and clocks on Glymur
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>
Patches: 2
Reviewed: 2026-03-04T07:43:55.780213
---
This is a single-patch fix for the Glymur DisplayPort DT bindings. It addresses two issues introduced in v6.19: the DP controller binding had incorrect register range constraints (5 instead of 9) by grouping Glymur with platforms that have a different register layout, and the MDSS example used wrong/incomplete register addresses. The fix is straightforward and correct — it moves `qcom,glymur-dp` out of the `sc8280xp-dp`/`x1e80100-dp` group into its own clause requiring all 9 register blocks, and updates the example to match.
There is one minor issue to flag: the patch perpetuates a pre-existing typo (`clocks-names` vs. `clock-names`).
**Verdict**: Looks good overall. One minor issue worth fixing.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 21:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 9:03 [PATCH v4] dt-bindings: display: msm: Fix reg ranges and clocks on Glymur Abel Vesa
2026-03-03 9:18 ` Johan Hovold
2026-03-03 21:43 ` Claude Code Review Bot [this message]
2026-03-03 21:43 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-02 9:58 [PATCH v3 0/2] dt-bindings: display: msm: Fix Glymur DP controller reg ranges and clock Abel Vesa
2026-03-02 9:58 ` [PATCH v3 1/2] dt-bindings: display: msm: Fix reg ranges and clocks on Glymur Abel Vesa
2026-03-03 3:37 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260303-glymur-fix-dp-bindings-reg-clocks-v4-1-1ebd9c7c2cee@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox