From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: goldfishfb: use devm_platform_ioremap_resource()
Date: Wed, 04 Mar 2026 07:21:04 +1000 [thread overview]
Message-ID: <review-overall-20260303-master-v1-1-85eb5ff584b0@gmail.com> (raw)
In-Reply-To: <20260303-master-v1-1-85eb5ff584b0@gmail.com>
Overall Series Review
Subject: fbdev: goldfishfb: use devm_platform_ioremap_resource()
Author: Amin GATTOUT <amin.gattout@gmail.com>
Patches: 3
Reviewed: 2026-03-04T07:21:04.586574
---
This is a single-patch series performing a standard kernel cleanup: replacing an open-coded `platform_get_resource()` + `ioremap()` pair with `devm_platform_ioremap_resource()` in the goldfish framebuffer driver, and removing the corresponding manual `iounmap()` calls. The patch is straightforward and largely correct, but has a couple of subtle behavioral changes worth noting.
**Verdict: Mostly clean, minor notes below.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-03 21:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 12:22 [PATCH] fbdev: goldfishfb: use devm_platform_ioremap_resource() Amin GATTOUT
2026-03-03 12:51 ` Thomas Zimmermann
2026-03-03 14:07 ` Helge Deller
2026-03-03 21:21 ` Claude review: " Claude Code Review Bot
2026-03-03 21:21 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260303-master-v1-1-85eb5ff584b0@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox