From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: pci: add abstractions for SR-IOV capability Date: Wed, 04 Mar 2026 08:40:15 +1000 Message-ID: In-Reply-To: <20260303-rust-pci-sriov-v3-0-4443c35f0c88@redhat.com> References: <20260303-rust-pci-sriov-v3-0-4443c35f0c88@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: rust: pci: add abstractions for SR-IOV capability Author: Peter Colberg Patches: 11 Reviewed: 2026-03-04T08:40:15.108262 --- This is a well-structured series adding Rust abstractions for PCI SR-IOV. The key architectural decision is sound: introducing a C-side `managed_sriov` driver flag that guarantees VFs are destroyed before the PF driver unbinds, which allows the Rust side to provide a safe `physfn()` API. The series builds incrementally with clean separation of concerns. The C-side changes (patches 1-2) are the foundation, the Rust wrappers (patches 3, 6-8) are straightforward, the vtable/callback plumbing (patches 4-5) is mechanical, and the `physfn()` safety argument (patch 9) is the centerpiece. The sample (patch 10) demonstrates the full lifecycle. No blocking issues found. A few observations and minor items below. --- --- Generated by Claude Code Patch Reviewer