From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: Include ioctl.h in UAPI header
Date: Tue, 03 Mar 2026 12:44:01 +1000 [thread overview]
Message-ID: <review-overall-20260303002309.1401849-1-isaacmanjarres@google.com> (raw)
In-Reply-To: <20260303002309.1401849-1-isaacmanjarres@google.com>
Overall Series Review
Subject: dma-buf: Include ioctl.h in UAPI header
Author: "Isaac J. Manjarres" <isaacmanjarres@google.com>
Patches: 2
Reviewed: 2026-03-03T12:44:01.978349
---
This is a single, straightforward patch that adds a missing `#include <linux/ioctl.h>` to the `include/uapi/linux/dma-buf.h` UAPI header. The fix is correct and well-motivated. The header uses `_IOW()` and `_IOWR()` macros (lines 171, 176-180 in the current tree) which are defined through `<linux/ioctl.h>`, but never includes that header. This means userspace programs that include `<linux/dma-buf.h>` without separately including `<linux/ioctl.h>` will get build failures due to undefined macros.
UAPI headers should be self-contained so that userspace can include them independently. This is a well-established kernel convention. The fix is minimal, correct, and low-risk.
**Verdict: Looks good. No issues found.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 2:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 0:23 [PATCH v1] dma-buf: Include ioctl.h in UAPI header Isaac J. Manjarres
2026-03-03 1:45 ` T.J. Mercier
2026-03-03 2:44 ` Claude Code Review Bot [this message]
2026-03-03 2:44 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260303002309.1401849-1-isaacmanjarres@google.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox