From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: Include ioctl.h in UAPI header Date: Tue, 03 Mar 2026 12:44:01 +1000 Message-ID: In-Reply-To: <20260303002309.1401849-1-isaacmanjarres@google.com> References: <20260303002309.1401849-1-isaacmanjarres@google.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: dma-buf: Include ioctl.h in UAPI header Author: "Isaac J. Manjarres" Patches: 2 Reviewed: 2026-03-03T12:44:01.978349 --- This is a single, straightforward patch that adds a missing `#include ` to the `include/uapi/linux/dma-buf.h` UAPI header. The fix is correct and well-motivated. The header uses `_IOW()` and `_IOWR()` macros (lines 171, 176-180 in the current tree) which are defined through ``, but never includes that header. This means userspace programs that include `` without separately including `` will get build failures due to undefined macros. UAPI headers should be self-contained so that userspace can include them independently. This is a well-established kernel convention. The fix is minimal, correct, and low-risk. **Verdict: Looks good. No issues found.** --- Generated by Claude Code Patch Reviewer