public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Update 'none' recovery method for DRM wedged event
Date: Wed, 04 Mar 2026 07:31:27 +1000	[thread overview]
Message-ID: <review-overall-20260303110556.3577612-1-raag.jadav@intel.com> (raw)
In-Reply-To: <20260303110556.3577612-1-raag.jadav@intel.com>

Overall Series Review

Subject: Update 'none' recovery method for DRM wedged event
Author: Raag Jadav <raag.jadav@intel.com>
Patches: 7
Reviewed: 2026-03-04T07:31:27.271209

---

This 3-patch series broadens the meaning of `WEDGED=none` to cover a new use case: the Xe driver's `XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET` debug mode, where the device is intentionally left wedged (no GT reset) so developers can inspect the hang state.

The core concern is a **UAPI semantic change**. The current documentation and log message for `WEDGED=none` imply the device was already recovered (via reset) and is functional again. This series repurposes it to also mean "device is permanently wedged, don't try to recover it" for the debug case. These are fundamentally different device states from userspace's perspective: in one case the device works; in the other, all IOCTLs are blocked and only a rebind can restore it. Any existing userspace consumer processing `WEDGED=none` as "device is healthy, carry on" would be broken by the new usage.

The series would benefit from clearer documentation that distinguishes these two scenarios, or alternatively, considering whether a different mechanism (perhaps `WEDGED=vendor-specific` or a new method) would better express the "permanently wedged for debug" semantic without changing the existing contract.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-03 21:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 11:05 [PATCH v1 0/3] Update 'none' recovery method for DRM wedged event Raag Jadav
2026-03-03 11:05 ` [PATCH v1 1/3] drm/doc: Update documentation for 'none' recovery method Raag Jadav
2026-03-03 15:32   ` Rodrigo Vivi
2026-03-03 21:31   ` Claude review: " Claude Code Review Bot
2026-03-03 11:05 ` [PATCH v1 2/3] drm: Update log " Raag Jadav
2026-03-03 15:33   ` Rodrigo Vivi
2026-03-03 21:31   ` Claude review: " Claude Code Review Bot
2026-03-03 11:05 ` [PATCH v1 3/3] drm/xe: Send 'none' recovery method for XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET Raag Jadav
2026-03-03 15:34   ` Rodrigo Vivi
2026-03-03 21:31   ` Claude review: " Claude Code Review Bot
2026-03-03 21:31 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260303110556.3577612-1-raag.jadav@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox