Claude review: drm/panel: Add Himax HX83121A panel driver

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/panel: Add Himax HX83121A panel driver
Author: Pengyu Luo <mitltlatltl@gmail.com>
Patches: 4
Reviewed: 2026-03-04T07:28:31.807619

---

This is a 2-patch series adding a new DRM panel driver for the Himax HX83121A Display Driver IC, supporting BOE and CSOT PPC357DB1-4 panels found in HUAWEI Matebook E Go series. The driver supports dual-DSI, DSC, and DCS-based backlight.

The overall structure is reasonable and follows existing panel driver patterns (particularly panel-novatek-nt36523.c for dual-DSI). However, there are several issues that need to be addressed:

1. **Major: `module_param` for DSC is a non-standard approach** - no other panel driver in the kernel uses a module parameter to toggle DSC. DSC capability should be determined from the panel descriptor or DT, not a runtime boot parameter that could lead to mismatched panel states.
2. **Major: Supply name mismatch between DT binding and driver code** - the binding defines `avdd-supply`/`avee-supply` but the driver requests `vsp`/`vsn`.
3. **Major: Missing `allOf` reference to `panel-common.yaml`** in the DT binding.
4. **Minor: Kconfig issues** - missing `DRM_DISPLAY_DSC_HELPER` / `DRM_DISPLAY_HELPER` selections needed for DSC helper usage.
5. **Moderate: The `bpc` field is never set** in the panel descriptors.

---

---
Generated by Claude Code Patch Reviewer