From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: ilitek-ili9882t: use gpiod_set_value_cansleep() Date: Wed, 04 Mar 2026 07:04:08 +1000 Message-ID: In-Reply-To: <20260303152124.187791-1-jkeeping@inmusicbrands.com> References: <20260303152124.187791-1-jkeeping@inmusicbrands.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/panel: ilitek-ili9882t: use gpiod_set_value_cansleep() Author: John Keeping Patches: 1 Reviewed: 2026-03-04T07:04:08.499180 --- This is a single, straightforward patch that mechanically replaces all `gpi= od_set_value()` calls with `gpiod_set_value_cansleep()` in the ilitek-ili98= 82t panel driver. The change is correct and well-motivated. All call sites = are in process context (`probe`, `prepare`, `unprepare`) where sleeping is = permitted, as evidenced by the surrounding `usleep_range()`, `msleep()`, `r= egulator_enable/disable()`, and `mipi_dsi_dcs_nop()` calls =E2=80=94 all of= which can sleep themselves. Using `gpiod_set_value_cansleep()` allows the = driver to work with I2C- or SPI-based GPIO expanders that require sleeping = for bus transactions. No issues found. This is a clean, correct fix. --- Generated by Claude Code Patch Reviewer