From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu/amdgpu_connectors: Use struct drm_edid Date: Wed, 04 Mar 2026 08:35:53 +1000 Message-ID: In-Reply-To: <20260303211823.76631-1-jpeisach@ubuntu.com> References: <20260303211823.76631-1-jpeisach@ubuntu.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/amdgpu/amdgpu_connectors: Use struct drm_edid Author: Joshua Peisach Patches: 3 Reviewed: 2026-03-04T08:35:53.790529 --- This 2-patch series converts the amdgpu connector code from the deprecated = `struct edid` / `drm_get_edid()` API to the modern opaque `struct drm_edid`= / `drm_edid_read_ddc()` API. The intent is correct and the direction is ri= ght =E2=80=94 this is a well-understood modernization pattern across DRM dr= ivers. **However, patch 2 introduces use-after-free bugs at every call site.** The= old `amdgpu_connector_free_edid()` both freed the EDID and set `amdgpu_con= nector->edid =3D NULL`. The replacement `drm_edid_free()` only frees the me= mory =E2=80=94 it cannot NULL out the caller's pointer. The patch fails to = add `amdgpu_connector->edid =3D NULL` after any of the `drm_edid_free()` ca= lls, leaving dangling pointers that are subsequently dereferenced. **This series should not be applied as-is.** --- --- Generated by Claude Code Patch Reviewer