From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm: Add Qualcomm Eliza SoC support
Date: Thu, 05 Mar 2026 13:31:09 +1000 [thread overview]
Message-ID: <review-overall-20260304-drm-display-eliza-v2-0-ea0579f62358@oss.qualcomm.com> (raw)
In-Reply-To: <20260304-drm-display-eliza-v2-0-ea0579f62358@oss.qualcomm.com>
Overall Series Review
Subject: drm/msm: Add Qualcomm Eliza SoC support
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Patches: 14
Reviewed: 2026-03-05T13:31:09.732019
---
This is a well-structured, straightforward SoC enablement series adding Qualcomm Eliza display support (DPU v12.4) to the MSM/DRM driver. The series follows established patterns from SM8750/SM8650/Glymur additions and is authored by an experienced contributor (Krzysztof Kozlowski). The dt-bindings, UBWC config, DPU catalog, and MDSS registration are all present and consistent.
One notable issue: the DPU catalog defines `eliza_cwb[]` but then references `sm8650_cwb` instead, making the local array dead code. This mirrors a pre-existing bug in the SM8750 catalog. There are also a couple of TODOs left in the code that should either be addressed or tracked.
Overall, the series looks ready with one issue to address in patch 7.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-05 3:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 12:58 [PATCH v2 0/8] drm/msm: Add Qualcomm Eliza SoC support Krzysztof Kozlowski
2026-03-04 12:58 ` [PATCH v2 1/8] dt-bindings: display/msm: dp-controller: Add Eliza SoC Krzysztof Kozlowski
2026-03-04 14:29 ` Dmitry Baryshkov
2026-03-05 3:31 ` Claude review: " Claude Code Review Bot
2026-03-04 12:58 ` [PATCH v2 2/8] dt-bindings: display/msm: dsi-phy-7nm: " Krzysztof Kozlowski
2026-03-05 3:31 ` Claude review: " Claude Code Review Bot
2026-03-04 12:58 ` [PATCH v2 3/8] dt-bindings: display/msm: dsi-controller-main: " Krzysztof Kozlowski
2026-03-05 3:31 ` Claude review: " Claude Code Review Bot
2026-03-04 12:58 ` [PATCH v2 4/8] dt-bindings: display/msm: qcom,sm8650-dpu: " Krzysztof Kozlowski
2026-03-05 3:31 ` Claude review: " Claude Code Review Bot
2026-03-04 12:58 ` [PATCH v2 5/8] dt-bindings: display/msm: qcom,eliza-mdss: " Krzysztof Kozlowski
2026-03-05 3:31 ` Claude review: " Claude Code Review Bot
2026-03-04 12:58 ` [PATCH v2 6/8] soc: qcom: ubwc: Add configuration " Krzysztof Kozlowski
2026-03-04 13:35 ` Konrad Dybcio
2026-03-04 14:03 ` Krzysztof Kozlowski
2026-03-04 13:58 ` Dmitry Baryshkov
2026-03-05 3:31 ` Claude review: " Claude Code Review Bot
2026-03-04 12:58 ` [PATCH v2 7/8] drm/msm/dpu: Add support for " Krzysztof Kozlowski
2026-03-04 14:29 ` Dmitry Baryshkov
2026-03-05 3:31 ` Claude review: " Claude Code Review Bot
2026-03-04 12:58 ` [PATCH v2 8/8] drm/msm/mdss: " Krzysztof Kozlowski
2026-03-05 3:31 ` Claude review: " Claude Code Review Bot
2026-03-05 3:31 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-03 13:07 [PATCH 0/8] drm/msm: Add Qualcomm Eliza SoC support Krzysztof Kozlowski
2026-03-03 21:15 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260304-drm-display-eliza-v2-0-ea0579f62358@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox