From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: Add Qualcomm Eliza SoC support Date: Thu, 05 Mar 2026 13:31:09 +1000 Message-ID: In-Reply-To: <20260304-drm-display-eliza-v2-0-ea0579f62358@oss.qualcomm.com> References: <20260304-drm-display-eliza-v2-0-ea0579f62358@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm: Add Qualcomm Eliza SoC support Author: Krzysztof Kozlowski Patches: 14 Reviewed: 2026-03-05T13:31:09.732019 --- This is a well-structured, straightforward SoC enablement series adding Qualcomm Eliza display support (DPU v12.4) to the MSM/DRM driver. The series follows established patterns from SM8750/SM8650/Glymur additions and is authored by an experienced contributor (Krzysztof Kozlowski). The dt-bindings, UBWC config, DPU catalog, and MDSS registration are all present and consistent. One notable issue: the DPU catalog defines `eliza_cwb[]` but then references `sm8650_cwb` instead, making the local array dead code. This mirrors a pre-existing bug in the SM8750 catalog. There are also a couple of TODOs left in the code that should either be addressed or tracked. Overall, the series looks ready with one issue to address in patch 7. --- Generated by Claude Code Patch Reviewer