From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm: restore GEM-related IOCTLs for KMS devices
Date: Thu, 05 Mar 2026 13:25:16 +1000 [thread overview]
Message-ID: <review-overall-20260304-msm-restore-ioctls-v1-1-b28f9231fcd2@oss.qualcomm.com> (raw)
In-Reply-To: <20260304-msm-restore-ioctls-v1-1-b28f9231fcd2@oss.qualcomm.com>
Overall Series Review
Subject: drm/msm: restore GEM-related IOCTLs for KMS devices
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 6
Reviewed: 2026-03-05T13:25:16.724865
---
This is a single-patch fix by Dmitry Baryshkov that restores a subset of GEM-related IOCTLs to the MSM KMS-only driver, which were removed by commit 98f11fd1cf92. The motivation is that the MSM GBM backend needs `MSM_GEM_NEW` to allocate buffers from the KMS device and then imports them into the GPU driver for rendering — dumb buffers should not be used for GPU rendering.
The patch is technically correct in its implementation (designated initializers in `DRM_IOCTL_DEF_DRV` handle array indexing properly). However, there are a few points worth discussing.
**Overall assessment:** Reasonable fix for a real regression, but some design questions remain about whether this is the right subset of ioctls and whether `MSM_INFO_GET_IOVA` / `MSM_INFO_SET_IOVA` sub-commands within `GEM_INFO` will behave correctly without a GPU.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-05 3:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 13:34 [PATCH] drm/msm: restore GEM-related IOCTLs for KMS devices Dmitry Baryshkov
2026-03-04 14:57 ` Rob Clark
2026-03-04 14:59 ` Rob Clark
2026-03-05 1:03 ` Dmitry Baryshkov
2026-03-04 15:57 ` Rob Clark
2026-03-05 0:44 ` Dmitry Baryshkov
2026-03-05 3:25 ` Claude Code Review Bot [this message]
2026-03-05 3:25 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260304-msm-restore-ioctls-v1-1-b28f9231fcd2@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox