From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: restore GEM-related IOCTLs for KMS devices Date: Thu, 05 Mar 2026 13:25:16 +1000 Message-ID: In-Reply-To: <20260304-msm-restore-ioctls-v1-1-b28f9231fcd2@oss.qualcomm.com> References: <20260304-msm-restore-ioctls-v1-1-b28f9231fcd2@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/msm: restore GEM-related IOCTLs for KMS devices Author: Dmitry Baryshkov Patches: 6 Reviewed: 2026-03-05T13:25:16.724865 --- This is a single-patch fix by Dmitry Baryshkov that restores a subset of GE= M-related IOCTLs to the MSM KMS-only driver, which were removed by commit 9= 8f11fd1cf92. The motivation is that the MSM GBM backend needs `MSM_GEM_NEW`= to allocate buffers from the KMS device and then imports them into the GPU= driver for rendering =E2=80=94 dumb buffers should not be used for GPU ren= dering. The patch is technically correct in its implementation (designated initiali= zers in `DRM_IOCTL_DEF_DRV` handle array indexing properly). However, there= are a few points worth discussing. **Overall assessment:** Reasonable fix for a real regression, but some desi= gn questions remain about whether this is the right subset of ioctls and wh= ether `MSM_INFO_GET_IOVA` / `MSM_INFO_SET_IOVA` sub-commands within `GEM_IN= FO` will behave correctly without a GPU. --- Generated by Claude Code Patch Reviewer