From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: mm: globalize rest_of_page() macro Date: Thu, 05 Mar 2026 13:59:10 +1000 Message-ID: In-Reply-To: <20260304012717.201797-1-ynorov@nvidia.com> References: <20260304012717.201797-1-ynorov@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: mm: globalize rest_of_page() macro Author: Yury Norov Patches: 16 Reviewed: 2026-03-05T13:59:10.320680 --- This is a straightforward tree-wide cleanup series that introduces a `rest_= of_page()` macro in `include/linux/mm.h` (extracted from net/9p's local hel= per) and replaces `PAGE_SIZE - offset_in_page(x)` patterns across 29 files.= The concept is sound =E2=80=94 this is a common idiom and having a named m= acro improves readability. No functional changes are intended. **Overall assessment: Low risk, mostly correct, a few minor issues.** The main concerns are: 1. Patch 7 has a misleading subject line ("drivers: ALSA") when it actually= touches null_blk, i915, dm-pcache, and virtio sound. 2. Patch 6 sneaks in a gratuitous type name change (`unsigned` =E2=86=92 `u= nsigned int`). 3. Patch 8 removes a blank line in the arm64 code, which is an unrelated st= yle change. --- --- Generated by Claude Code Patch Reviewer