From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/v3d: Using spin_lock_irqsave instead of spin_lock in the RT kernel
Date: Thu, 05 Mar 2026 13:49:50 +1000 [thread overview]
Message-ID: <review-overall-20260304031724.246404-1-xiaolei.wang@windriver.com> (raw)
In-Reply-To: <20260304031724.246404-1-xiaolei.wang@windriver.com>
Overall Series Review
Subject: drm/v3d: Using spin_lock_irqsave instead of spin_lock in the RT kernel
Author: Xiaolei Wang <xiaolei.wang@windriver.com>
Patches: 2
Reviewed: 2026-03-05T13:49:50.617735
---
This is a single patch attempting to fix an RT kernel warning in v3d's `v3d_job_update_stats()` by replacing the `spin_lock()` + manual `local_irq_save()`/`preempt_disable()` pattern with `spin_lock_irqsave()`. While the motivation is valid (the current code causes a sleeping-in-atomic warning on PREEMPT_RT), the patch has a **correctness bug** and is **incomplete**.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-05 3:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 3:17 [PATCH] drm/v3d: Using spin_lock_irqsave instead of spin_lock in the RT kernel Xiaolei Wang
2026-03-04 10:21 ` Maíra Canal
2026-03-05 3:49 ` Claude review: " Claude Code Review Bot
2026-03-05 3:49 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260304031724.246404-1-xiaolei.wang@windriver.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox