public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Introduce DRM_RAS using generic netlink for RAS
Date: Thu, 05 Mar 2026 13:47:40 +1000	[thread overview]
Message-ID: <review-overall-20260304074412.464435-7-riana.tauro@intel.com> (raw)
In-Reply-To: <20260304074412.464435-7-riana.tauro@intel.com>

Overall Series Review

Subject: Introduce DRM_RAS using generic netlink for RAS
Author: Riana Tauro <riana.tauro@intel.com>
Patches: 6
Reviewed: 2026-03-05T13:47:40.227283

---

This series introduces a DRM RAS (Reliability, Availability, Serviceability) infrastructure over generic netlink, along with the first Xe driver implementation for PVC (Ponte Vecchio). The architecture is reasonable: a core DRM RAS layer manages nodes in an xarray, exposes them via genetlink, and drivers register nodes with error counter callbacks. The series is at v10 and has several acks/reviews, but there are still several bugs and design concerns worth addressing.

**Key issues:**
1. **Memory leak in `doit_reply_value()`** — `msg` skb is leaked on `get_node_error_counter()` failure.
2. **Uninitialized `ret` in `drm_ras_nl_list_nodes_dumpit()`** — returns garbage if xarray is empty.
3. **No locking around xarray access** — concurrent register/unregister vs. netlink queries is racy.
4. **`error-value` uses u32** — but counters use `atomic_t` which can overflow; also `hweight32` accumulation can produce inflated counts.
5. **Correctable errors skip all register reads in SoC handler** — just clears with all-1s, losing diagnostic information.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-05  3:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04  7:44 [PATCH v10 0/5] Introduce DRM_RAS using generic netlink for RAS Riana Tauro
2026-03-04  7:44 ` [PATCH v10 1/5] drm/ras: Introduce the DRM RAS infrastructure over generic netlink Riana Tauro
2026-03-05  3:47   ` Claude review: " Claude Code Review Bot
2026-03-04  7:44 ` [PATCH v10 2/5] drm/xe/xe_drm_ras: Add support for XE DRM RAS Riana Tauro
2026-03-05  3:47   ` Claude review: " Claude Code Review Bot
2026-03-04  7:44 ` [PATCH v10 3/5] drm/xe/xe_hw_error: Integrate DRM RAS with hardware error handling Riana Tauro
2026-03-05  3:47   ` Claude review: " Claude Code Review Bot
2026-03-04  7:44 ` [PATCH v10 4/5] drm/xe/xe_hw_error: Add support for Core-Compute errors Riana Tauro
2026-03-05  3:47   ` Claude review: " Claude Code Review Bot
2026-03-04  7:44 ` [PATCH v10 5/5] drm/xe/xe_hw_error: Add support for PVC SoC errors Riana Tauro
2026-03-05  3:47   ` Claude review: " Claude Code Review Bot
2026-03-05  3:47 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-02-28  8:08 [PATCH v9 0/5] Introduce DRM_RAS using generic netlink for RAS Riana Tauro
2026-03-03  4:32 ` Claude review: " Claude Code Review Bot
2026-02-23  6:05 [PATCH v8 0/5] " Riana Tauro
2026-02-24  0:45 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260304074412.464435-7-riana.tauro@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox