From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: bridge: anx7625: enforce CONFIG_USB_ROLE_SWITCH dependency
Date: Thu, 05 Mar 2026 13:44:42 +1000 [thread overview]
Message-ID: <review-overall-20260304083604.724519-1-arnd@kernel.org> (raw)
In-Reply-To: <20260304083604.724519-1-arnd@kernel.org>
Overall Series Review
Subject: drm: bridge: anx7625: enforce CONFIG_USB_ROLE_SWITCH dependency
Author: Arnd Bergmann <arnd@kernel.org>
Patches: 1
Reviewed: 2026-03-05T13:44:42.327497
---
This is a single, well-motivated build fix patch. The problem is clearly described: when `CONFIG_TYPEC=y` but `USB_ROLE_SWITCH=m`, the anx7625 driver fails to link as built-in because it calls `usb_role_switch_*` functions from a module. The original Kconfig used the idiom `depends on TYPEC || !TYPEC` which makes TYPEC optional, and the C code had `#if IS_REACHABLE(CONFIG_TYPEC)` guards with stub fallbacks. However, USB_ROLE_SWITCH had no such protection, leading to the link failure.
The fix is clean and pragmatic: make both TYPEC and USB_ROLE_SWITCH hard dependencies, and remove the now-unnecessary `#if IS_REACHABLE()` / `#else` stub code. The rationale that any real user of this hardware would have both enabled is sound.
**Verdict: Looks good.** No issues found.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-05 3:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 8:35 [PATCH] drm: bridge: anx7625: enforce CONFIG_USB_ROLE_SWITCH dependency Arnd Bergmann
2026-03-05 3:44 ` Claude Code Review Bot [this message]
2026-03-05 3:44 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260304083604.724519-1-arnd@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox