From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: anx7625: enforce CONFIG_USB_ROLE_SWITCH dependency Date: Thu, 05 Mar 2026 13:44:42 +1000 Message-ID: In-Reply-To: <20260304083604.724519-1-arnd@kernel.org> References: <20260304083604.724519-1-arnd@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: bridge: anx7625: enforce CONFIG_USB_ROLE_SWITCH dependency Author: Arnd Bergmann Patches: 1 Reviewed: 2026-03-05T13:44:42.327497 --- This is a single, well-motivated build fix patch. The problem is clearly described: when `CONFIG_TYPEC=y` but `USB_ROLE_SWITCH=m`, the anx7625 driver fails to link as built-in because it calls `usb_role_switch_*` functions from a module. The original Kconfig used the idiom `depends on TYPEC || !TYPEC` which makes TYPEC optional, and the C code had `#if IS_REACHABLE(CONFIG_TYPEC)` guards with stub fallbacks. However, USB_ROLE_SWITCH had no such protection, leading to the link failure. The fix is clean and pragmatic: make both TYPEC and USB_ROLE_SWITCH hard dependencies, and remove the now-unnecessary `#if IS_REACHABLE()` / `#else` stub code. The rationale that any real user of this hardware would have both enabled is sound. **Verdict: Looks good.** No issues found. --- Generated by Claude Code Patch Reviewer