From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/fbdev: fix link failure without FBDEV emulation Date: Thu, 05 Mar 2026 13:43:28 +1000 Message-ID: In-Reply-To: <20260304083701.724908-1-arnd@kernel.org> References: <20260304083701.724908-1-arnd@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/i915/fbdev: fix link failure without FBDEV emulation Author: Arnd Bergmann Patches: 2 Reviewed: 2026-03-05T13:43:28.995608 --- This is a single-patch fix for a link error that occurs when `CONFIG_DRM_FBDEV_EMULATION=n` but `CONFIG_FRAMEBUFFER_CONSOLE=y`. The function `intel_fbdev_fb_prefer_stolen()` lives in `intel_fbdev_fb.c`, which is only compiled when `CONFIG_DRM_FBDEV_EMULATION` is enabled (confirmed by the Makefile at line 325-327). The original code only guarded the call with `IS_ENABLED(CONFIG_FRAMEBUFFER_CONSOLE)`, which is insufficient since `CONFIG_FRAMEBUFFER_CONSOLE` can be enabled independently. The fix is correct, minimal, and well-targeted. Adding the `IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION)` check ensures the call to `intel_fbdev_fb_prefer_stolen()` is compiled out when the object file providing that symbol isn't built. **Verdict: Good to merge.** --- Generated by Claude Code Patch Reviewer