From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe/tests: avoid build warning on 32-bit targets
Date: Thu, 05 Mar 2026 13:42:12 +1000 [thread overview]
Message-ID: <review-overall-20260304083741.725121-1-arnd@kernel.org> (raw)
In-Reply-To: <20260304083741.725121-1-arnd@kernel.org>
Overall Series Review
Subject: drm/xe/tests: avoid build warning on 32-bit targets
Author: Arnd Bergmann <arnd@kernel.org>
Patches: 3
Reviewed: 2026-03-05T13:42:12.647626
---
This is a single-patch fix for a 32-bit build warning in the Xe KUnit tests. The problem is real: `TEST_VRAM` (0x37a800000, ~14.9 GiB) is assigned to a `resource_size_t` field (`usable_size`), which is only 32 bits wide on 32-bit targets, causing silent truncation and a `-Werror=overflow` build failure.
However, the proposed fix of casting with `(resource_size_t)` is a band-aid that **silences the warning while making the tests silently broken on 32-bit**. The value truncates to ~1.9 GiB, which would change the semantics of multiple test cases that use `TEST_VRAM`. The author acknowledges this in the commit message and cover letter, essentially offering it as a bug report.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-05 3:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 8:37 [PATCH] drm/xe/tests: avoid build warning on 32-bit targets Arnd Bergmann
2026-03-04 8:51 ` Michal Wajdeczko
2026-03-04 9:06 ` Arnd Bergmann
2026-03-05 3:42 ` Claude review: " Claude Code Review Bot
2026-03-05 3:42 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260304083741.725121-1-arnd@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox