From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: amdgpu,radeon: Test fbdev GEM object in helper Date: Thu, 05 Mar 2026 13:27:24 +1000 Message-ID: In-Reply-To: <20260304130250.59008-1-tzimmermann@suse.de> References: <20260304130250.59008-1-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: amdgpu,radeon: Test fbdev GEM object in helper Author: Thomas Zimmermann Patches: 5 Reviewed: 2026-03-05T13:27:24.252186 --- This is a clean, straightforward refactoring series by Thomas Zimmermann th= at extracts a common pattern =E2=80=94 "is this GEM object the fbdev frameb= uffer?" =E2=80=94 from both amdgpu and radeon into a single generic helper = `drm_fb_helper_gem_is_fb()` in the DRM core. The series is well-structured:= patch 1 introduces the helper and converts amdgpu, patch 2 converts radeon= . No functional changes are intended, and the logic looks correct. One issue to flag: the export symbol type is inconsistent with the rest of = the file. --- Generated by Claude Code Patch Reviewer