From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova: add impl_num_enum!() macro to replace FromPrimitive boilerplate
Date: Thu, 05 Mar 2026 13:19:42 +1000
Message-ID: <review-overall-20260304181420.5482-1-iprintercanon@gmail.com>
In-Reply-To: <20260304181420.5482-1-iprintercanon@gmail.com>
References: <20260304181420.5482-1-iprintercanon@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Overall Series Review

Subject: gpu: nova: add impl_num_enum!() macro to replace FromPrimitive boi=
lerplate
Author: Artem Lytkin <iprintercanon@gmail.com>
Patches: 1
Reviewed: 2026-03-05T13:19:42.473891

---

This is a single-patch series that introduces a declarative macro `impl_num=
_enum!()` to replace repetitive `From<Enum> for u8` and `TryFrom<u8> for En=
um` boilerplate across the nova-core driver. The motivation is sound =E2=80=
=94 it addresses explicit `TODO[FPRI]` markers in the codebase and substant=
ially reduces boilerplate. The patch is well-scoped and the commit message =
is clear about what is and isn't changed, and why.

The patch is generally good. There are a few points worth discussing, but n=
o correctness bugs.

---
Generated by Claude Code Patch Reviewer