From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Improve v3d_stats lifetime and locking Date: Mon, 09 Mar 2026 09:20:14 +1000 Message-ID: In-Reply-To: <20260305-v3d-reset-locking-improv-v2-0-fd53c91f7726@igalia.com> References: <20260305-v3d-reset-locking-improv-v2-0-fd53c91f7726@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/v3d: Improve v3d_stats lifetime and locking Author: =?utf-8?q?Ma=C3=ADra_Canal?= Patches: 7 Reviewed: 2026-03-09T09:20:14.843131 --- This is a well-structured 6-patch series that improves `v3d_stats` lifetime management by converting embedded stats structs to heap-allocated, refcounted objects. The core motivation is sound: eliminating the tricky `file_priv` NULL-ing dance that was needed to handle the race between per-fd GPU stats updates and fd release. The refcounting approach is clean, the error handling paths are correct, and the series progressively simplifies the locking scheme. The patches are logically ordered and each builds on the previous one. No blocking issues found. A few minor observations below. --- Generated by Claude Code Patch Reviewer