From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: add continuation record support Date: Mon, 09 Mar 2026 09:11:25 +1000 Message-ID: In-Reply-To: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> References: <20260306-cmdq-continuation-v6-0-cc7b629200ee@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: gpu: nova-core: gsp: add continuation record support Author: Eliot Courtney Patches: 10 Reviewed: 2026-03-09T09:11:25.577837 --- This is a well-structured 9-patch series adding continuation record support for the nova-core GSP command queue. Large RPCs (>16 pages / 64KB) need to be split across multiple queue elements, and this series implements that cleanly. The patches are logically decomposed: preparatory cleanups (sorting, timeout mechanism, size checking), then the core continuation record implementation, followed by tests. The code quality is high. The `SplitState` design avoids unnecessary copies for commands that fit in a single element, and the `ContinuationRecords` iterator pattern keeps the splitting logic contained. The tests cover important boundary conditions. This is at v6 with prior reviews incorporated. **Minor observations** are noted below per-patch, but overall this series looks good to merge. --- Generated by Claude Code Patch Reviewer