From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: add Turing support Date: Mon, 09 Mar 2026 09:15:13 +1000 Message-ID: In-Reply-To: <20260306-turing_prep-v11-0-8f0042c5d026@nvidia.com> References: <20260306-turing_prep-v11-0-8f0042c5d026@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: gpu: nova-core: add Turing support Author: Alexandre Courbot Patches: 14 Reviewed: 2026-03-09T09:15:13.248768 --- This is a well-structured v11 series adding Turing GPU support to the nova-= core Rust driver. The series progresses logically: first refactoring the fi= rmware loading infrastructure (patches 1-5), then adding PIO loading suppor= t (patch 6), fixing/documenting firmware headers (patches 7-9), and finally= implementing the Generic Bootloader for FWSEC on Turing (patches 10-12). The code quality is generally good =E2=80=94 the move from `DmaObject`-back= ed storage to `KVVec` in patch 1 is a meaningful safety improvement that el= iminates 8 `unsafe` blocks. The refactoring patches are clean and logical. = The new bootloader code in patch 12 is well-documented with clear comments = explaining the firmware layout expectations. A few issues are worth raising, mostly around arithmetic safety and a misor= dering in the mbox. --- Generated by Claude Code Patch Reviewer