From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Improve v3d_stats lifetime and locking Date: Mon, 09 Mar 2026 08:56:08 +1000 Message-ID: In-Reply-To: <20260306-v3d-reset-locking-improv-v3-0-49864fe00692@igalia.com> References: <20260306-v3d-reset-locking-improv-v3-0-49864fe00692@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/v3d: Improve v3d_stats lifetime and locking Author: =?utf-8?q?Ma=C3=ADra_Canal?= Patches: 7 Reviewed: 2026-03-09T08:56:08.355925 --- This is a well-structured series that improves the lifetime management of `v3d_stats` by converting them from embedded structs to heap-allocated, refcounted objects. The core motivation is sound: the previous approach used a fragile `file_priv` NULL-ing dance under `queue_lock` to handle the race between fd closure and stats updates in the IRQ handler. By giving each job its own kref'd reference to the stats, the race is eliminated cleanly. The series is logically ordered with good incremental steps: error handling fix, lockdep cleanup, refcounting introduction, per-job references, reset counter migration, and finally lock removal. Each patch has a clear purpose and the overall result simplifies both locking and lifetime management. One bug was spotted in the read-side seqcount usage. The series is otherwise solid. --- Generated by Claude Code Patch Reviewer