From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: Wrap dcn32_override_min_req_memclk() in DC_FP_{START, END}
Date: Mon, 09 Mar 2026 09:08:52 +1000 [thread overview]
Message-ID: <review-overall-20260306062805.1464383-2-xry111@xry111.site> (raw)
In-Reply-To: <20260306062805.1464383-2-xry111@xry111.site>
Overall Series Review
Subject: drm/amd/display: Wrap dcn32_override_min_req_memclk() in DC_FP_{START, END}
Author: Xi Ruoyao <xry111@xry111.site>
Patches: 1
Reviewed: 2026-03-09T09:08:52.939278
---
This is a single-patch series that fixes a missing FP context save/restore around a call to `dcn32_override_min_req_memclk()`. The function lives in `dcn32_fpu.c`, which is compiled with `CC_FLAGS_FPU` (enabling FP instructions). On architectures like LoongArch where the FPU isn't always enabled, calling into FPU-compiled code without the proper `DC_FP_START()`/`DC_FP_END()` guards will cause faults or incorrect behavior.
The fix is correct, minimal, and follows the established pattern already used throughout the same file (e.g., the `dcn32_internal_validate_bw()` call at lines 1770-1771 uses the same `DC_FP_START/END` wrapping). The `Fixes:` tag and `Cc: stable` are appropriate since this is a real bug that affects users on LoongArch.
**Verdict: Good to merge.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-08 23:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 6:28 [PATCH] drm/amd/display: Wrap dcn32_override_min_req_memclk() in DC_FP_{START, END} Xi Ruoyao
2026-03-08 23:08 ` Claude Code Review Bot [this message]
2026-03-08 23:08 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260306062805.1464383-2-xry111@xry111.site \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox